Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 8b8e5f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cafa3ab6-d90a-4f88-8953-d754886f57a4
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the draft-only implementation and accompanying coverage; tests were not executed.
0 open findings
What changed in this PR
Adds prepare_feedback to the Primer MCP server to generate reviewable issue drafts without submitting them.
Changes:
- Adds validated feedback drafts with reproduction details, outcomes, and optional links.
- Defaults to
github/primer, with a guarded public-repository fallback. - Adds integration tests and a minor-release changeset.
| File | Description |
|---|---|
| packages/mcp/src/server.ts | Registers the feedback tool. |
| packages/mcp/src/server.test.ts | Tests draft generation, validation, and repository selection. |
| packages/mcp/src/feedback.ts | Implements feedback guidance, schemas, and draft generation. |
| .changeset/agent-feedback-drafts.md | Records the new MCP feature for release. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: cafa3ab6-d90a-4f88-8953-d754886f57a4
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cafa3ab6-d90a-4f88-8953-d754886f57a4
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/7254
Add
prepare_feedbackto the MCP server to prepare reviewable feedback drafts without submitting issues. Feedback defaults togithub/primer, withprimer/reactavailable only when the user cannot create an issue ingithub/primer.Drafts include a minimal reproduction attempt (or an explicit user-requested skip), optional related links, and the final task outcome. Timing and privacy guidance live in the tool description, not server-wide initialization instructions.
Drafts use a prefilled issue link within a conservative 6,000-byte URL budget. Larger drafts return structured
gh issue createarguments so the agent can offer to submit on the user's behalf after explicit approval, passing the full body through stdin. The tool never executes the command or files an issue itself.Changelog
New
prepare_feedbackfor the eight feedback categories, with reproduction details, optional related links, and blocked, worked-around, or resolved task outcomes.Changed
Removed
Rollout strategy
Testing & Reviewing