Repository navigation
perf(react-compiler): enable useSafeTimeout, token remove buttons, and UnderlinePanels - #8555
Conversation
🦋 Changeset detectedLatest commit: 4fa9b73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Integration test results from github/github-ui PR: |
09e8fdb to
4fa9b73
Compare
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in these focused compatibility refactors; tests and compilation were not run.
No open issues 🎉
What changed in this PR
Enables React Compiler for useSafeTimeout, private token remove buttons, and experimental UnderlinePanels.
Changes:
- Refactors timer cleanup, unused ref handling, and positional counters for compiler compatibility.
- Removes compiler exclusions for all three implementations.
- Adds minor changesets documenting the rollout.
| File | Description |
|---|---|
| packages/react/src/Token/_RemoveTokenButton.tsx | Removes unused explicit ref handling. |
| packages/react/src/hooks/useSafeTimeout.ts | Captures the shared timer Set for cleanup. |
| packages/react/src/experimental/UnderlinePanels/UnderlinePanels.tsx | Groups positional counters in a local object. |
| packages/react/script/react-compiler.mjs | Removes three compiler exclusions. |
| .changeset/react-compiler-underline-panels.md | Documents UnderlinePanels compiler support. |
| .changeset/react-compiler-token-remove-button.md | Documents token rendering improvements. |
| .changeset/react-compiler-safe-timeout.md | Documents timeout hook compiler support. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
4fa9b73 to
64fce7b
Compare
Enable React Compiler for
useSafeTimeout, the private token remove button, and UnderlinePanels. This combines the small migrations from #8553, #8554, and this PR into one review without changing their implementation.Our migration report identifies the cleanup ref access, ref handling through remaining props, and captured positional counters as the respective blockers.
Changelog
New
Changed
useSafeTimeouteffect runs. Cleanup retains the same mutable Set, including timers registered after the effect.Removed
Rollout strategy