Repository navigation
Remove Popover arrows - #8581
Draft
JannesPeters wants to merge 2 commits into
Draft
JannesPeters wants to merge 2 commits into
JannesPeters wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
JannesPeters
requested review from
siddharthkp
and
a balanced review from Copilot
October 20, 2026 12:52
🦋 Changeset detectedLatest commit: a447de4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Canonical visual baselines need updating, and pending product-context evidence requires human visual confirmation.
1 open issue
What changed in this PR
Removes Popover’s visible arrows while preserving existing alignment and the public API.
Changes:
- Removes arrow pseudo-element styles, retaining content offsets.
- Clarifies the retained
caretbehavior. - Adds an
@primer/reactpatch changeset.
| File | Description |
|---|---|
| packages/react/src/Popover/Popover.module.css | Removes arrows while preserving alignment. |
| packages/react/src/Popover/Popover.docs.json | Documents retained caret behavior. |
| .changeset/popover-remove-arrow.md | Records the appearance change. |
Review effort: Balanced
JannesPeters
marked this pull request as draft
October 20, 2026 14:51
Regenerate all 27 active Popover screenshots with the pinned Playwright 1.60.0 Jammy Linux browser. The three dark-dimmed captures also pick up existing text-token drift, confirmed separately with the original Popover CSS. A clean comparison run passes all 27 cases. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

N/A — no linked issue.
Remove the visible arrow from Popover in every direction. Preserve the existing content alignment, dimensions, open/close interactions,
caretprop, anddata-caretattribute. Update thecaretdocumentation to describe its retained alignment behavior.Before and after
The existing
PullRequestFilesToolbarproduct component fromgithub/github-ui, rendered in its Storybook with the single-file-mode onboarding Popover open. These are product-component Storybook screenshots, not the live/fullstack GitHub app.The baseline uses the Popover CSS from
0d5607c3b29ab090a0a97d1532fdc3a066a37d3d; the updated view integrates the CSS froma447de40b6ec527f1f68b6d65b1f18393a3bf9f0through a temporary dependency source override, not browser-injected styling. Viewport, light theme, content, and open state are matched. Only the arrow changes; the existing skeleton animation was paused in both captures.Changelog
New
Changed
caretvalues; existing content alignment is unchanged.caretbehavior in the prop documentation.Removed
Rollout strategy
An
@primer/reactpatch changeset is included. Existing consumers retain the same API and positioning; the styling changes when the package is upgraded.Testing & Reviewing
npm test -- --run Popover— passed, 19 tests.npm run build— passed on a standalone rerun. The initial run alongside type-check hit anEEXISTrace creating the generated directory.npm run type-check— passed.npm run lint— passed.npm run lint:css— passed.npm run format:diff— passed.npm run format— passed.npm run lint:fix— passed.::before/::afterarrow and no visible rendering error.