Repository navigation
Raise TypeError when a task is called without a context - #1098
Open
Hugohong258 wants to merge 1 commit into
Open
Hugohong258 wants to merge 1 commit into
Hugohong258 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling a valid task with no arguments currently indexes
args[0]before checking the required Context, leakingIndexError: tuple index out of range. Check for an empty argument tuple first so the existing TypeError guard handles the call. The regression also verifies that the task's call counter stays unchanged.Validation: the new regression fails with IndexError on the base. On WSL Linux/Python 3.14.4, 109 related task/executor tests pass and 1 is skipped. Windows/Python 3.12.3 and Linux/Python 3.14.4 checks verify the error and a subsequent valid call. Black 22.8, Flake8 4 with an external host entry-point API adapter, and mypy 0.971 over all 48 source files pass. The adapter excludes unrelated host plugins and preserves normal noqa handling. The full unit suite, integrations and older-runtime CI matrix were not run. Based on the 2.2 release line per the contribution guide.