Repository navigation
Conversation
|
All commit authors signed the Contributor License Agreement. |
Contributor
|
this looks good to me. it needs a ruff format pass, and so far we didn't have unittests for the tooling in this repo, so this would be the first one. since the intent is that all of this is temporary, I'm not sure if we want unittests, but I also don't object (I like tests), so I'd want @brettcannon's input on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch_path()currently pads a replacement prefix with NUL bytes before the rest of the path. ReplacingPLACEHOLDER/lib/python3.16therefore leaves C string readers seeing only the installation prefix, without/lib/python3.16.Replace placeholders within each binary string, then pad its end. This preserves the path suffix and the original byte length, including when the same string contains multiple placeholders.
Skip
.pycand.pyofiles because their marshalled strings are length-prefixed. Applying raw binary prefix replacement to them can insert NUL bytes into storedco_filenamevalues.