Post with file parameter order #2115

Activity

1. kyugoa

   added

   bug

   on Jul 14, 2023
2. b166er commented on Jul 14, 2023

   

   b166er

   on Jul 14, 2023

   Last edited by b166er

   More actions

   I have the same problem!

   my first code, was very simple and naive. unfortunately it did not work as i expected:

   // Create RestClient
   RestClient client = new RestClient("https://api-server");
   
   // Create RestRequest
   RestRequest request = new RestRequest("path", Method.POST) {FormBoundary = "MySpecialBounderyIdentifierTest123"};
   
   request.AddJsonBody(myJsonData);
   request.AddFile(filename, fileContent, filename);
   
   // overwrite Content-Type with my custom requirement
   request.AddOrUpdateHeader("Content-Type", "multipart/mixed");
   
   // Execute the request
   IRestResponse response = client.Execute(request);
   
   // Handle the response
   if (response.IsSuccessful)
   {
       Console.WriteLine("File uploaded successfully!");
   }
   else
   {
       Console.WriteLine("File upload failed. Error: " + response.ErrorMessage);
   } 

   output with Version 110.2.0 is:

   Authorization: Basic myloginauthkey
   Accept: application/json, text/json, text/x-json, text/javascript, application/xml, text/xml
   User-Agent: RestSharp/110.2.0.0
   Content-Type: multipart/mixed; 
   boundary="MySpecialBounderyIdentifierTest123"
   Host: api-server
   Content-Length: 123
   Connection: Keep-Alive
   
   --MySpecialBounderyIdentifierTest123
   Content-Type: application/zip
   Content-Disposition: form-data; name="mytest.zip"; filename="mytest.zip"
   ...binary-bytes...
   --MySpecialBounderyIdentifierTest123
   Content-Type: application/json; charset=utf-8
   Content-Disposition: form-data; name="application/json"
   {"meta": [{"title": "My Homework","author": {"name": "Tessa","adress": null},"created": 1550743894373}]}
   --MySpecialBounderyIdentifierTest123--
   

   my expected output was:

   Authorization: Basic myloginauthkey
   Accept: application/json, text/json, text/x-json, text/javascript, application/xml, text/xml
   User-Agent: RestSharp/110.2.0.0
   Content-Type: multipart/mixed; boundary="MySpecialBounderyIdentifierTest123"
   Host: api-server
   Content-Length: 123
   Connection: Keep-Alive
   
   --MySpecialBounderyIdentifierTest123
   Content-Type: application/json; charset=utf-8
   Content-Disposition: form-data; name="application/json"
   {"meta": [{"title": "My Homework","author": {"name": "Tessa","adress": null},"created": 1550743894373}]}
   --MySpecialBounderyIdentifierTest123
   Content-Type: application/zip
   Content-Disposition: form-data; name="mytest.zip"; filename="mytest.zip"
   ...binary-bytes...
   --MySpecialBounderyIdentifierTest123--
   

   Here is my ugly code to set the order manually. It would be so great if the output of the parameters were in the same order as the executing Add-Methods, or at least some simple functionality to set the order, e.g. an order parameter.

   using System.Text;
   using System.Linq;
   
   class Program
   {
       static void Main(string[] args)
       {
           // Create RestClient
           RestClient client = new RestClient("https://api-server");
           
           // Create RestRequest
           RestRequest request = new RestRequest("path", Method.POST);
           
           string boundary = "MySpecialBounderyIdentifierTest123";
           string filename = "mytest.zip";
           
           // set manually content and encode all data to bytes
           byte[] start = Encoding.UTF8.GetBytes($"--{boundary}{Environment.NewLine}");
           byte[] separator = Encoding.UTF8.GetBytes($"{Environment.NewLine}{boundary}--{Environment.NewLine}");
           byte[] end = Encoding.UTF8.GetBytes($"{Environment.NewLine}--{boundary}--{Environment.NewLine}");
           
           string json = @"{
               ""meta"": [{
                       ""title"": ""My Homework"",
                       ""author"": 
                       {
                           ""name"": ""Tessa"",
                           ""adress"": null
                       }, 
                       ""created"": 1550743894373
                   }]
           }";
           // Content-Disposition is optional and not necessary for me/the api-server
           byte[] jsonMeta = Encoding.UTF8.GetBytes($"Content-Type: application/json{Environment.NewLine}{Environment.NewLine}{json}");
           byte[] fileMeta = Encoding.UTF8.GetBytes($"Content-Type: application/zip{Environment.NewLine}Content-Disposition: form-data; name=\"file\"; filename=\"{filename}\"{Environment.NewLine}{Environment.NewLine}");
           
           // use Linqs byte-concatenation
           IEnumerable<byte> requestBytes;
           
           // Combine first json data, then file content! the order is very important.
           requestBytes = start // start with boundary-start-sequence
               .Concat(jsonMeta) // important: json Data MUST be in the first position, before binary file payload
               .Concat(separator) // add boundary separator
               .Concat(fileMeta) // file data need as second parameter, after json data!
               .Concat(File.ReadAllBytes(filename)) // add file binary payload data as bytes
               .Concat(end) // add boundary-endsequence
           ;
           
           // in my personal case, I have to set an additional custom Content-Type Header
           // multipart/form-data does not work with my particular api-server!
           string header = $"multipart/mixin; boundary={boundary}";
   
           // set manually header and byte-content to parameter
           request.AddParameter(header, requestBytes.toArray(), ParameterType.RequestBody);
           
           // Execute the request
           IRestResponse response = client.Execute(request);
           
           // Handle the response
           if (response.IsSuccessful)
           {
               Console.WriteLine("File uploaded successfully!");
           }
           else
           {
               Console.WriteLine("File upload failed. Error: " + response.ErrorMessage);
           }       
       }
   }
3. koo9 commented on Jul 14, 2023

   

   koo9

   on Jul 14, 2023

   More actions

   just render the paramter by the order added would be sufficient. I believe you can set the file content type in the .AddFile() method but the overall content-type is still multipart/form-data

   👍React with 👍1Reacted by John Doe
4. alexeyzimarev

   removed

   bug

   on Jul 15, 2023
5. alexeyzimarev

   changed the title [-]Post with file parameter order bug[/-] [+]Post with file parameter orde[/+] on Jul 15, 2023
6. alexeyzimarev

   changed the title [-]Post with file parameter orde[/-] [+]Post with file parameter order[/+] on Jul 15, 2023
7. alexeyzimarev

   added

   feature-request

   on Jul 15, 2023
8. alexeyzimarev commented on Jul 15, 2023

   

   alexeyzimarev

   on Jul 15, 2023

   Member

   More actions

   Body parameters are added to the request message in the same order as they are added to RestRequest. But, files are added separately, as well as POST parameters when the content is a multipart form.
9. alexeyzimarev commented on Jul 15, 2023

   

   alexeyzimarev

   on Jul 15, 2023

   Member

   More actions

   Duplicate of #2098
10. alexeyzimarev

    marked this as a duplicate of Make parameters order in a post query configurable #2098 on Jul 15, 2023
11. alexeyzimarev

    closed this as completedon Jul 15, 2023
12. repo-ranger

    added

    duplicate

    on Jul 15, 2023