Repository navigation
Fix/ref prop preserve field alignment - #164600
Open
YunusMutlu wants to merge 2 commits into
Open
YunusMutlu wants to merge 2 commits into
YunusMutlu wants to merge 2 commits into
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @jieyouxu (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? mir-opt |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164599
Summary
Problem: A read through a raw
u32field pointer can be transformed byReferencePropagationinto an access through a misalignedAligned8pointer.Fix: This change adds a conservative guard that prevents potentially unsafe raw-pointer field projections from being recorded as replacement targets.
Validation: I reproduced the
align 8versusalign 4difference on both stable and nightly Rust. I also ran the codegen regression tests, the negative MIR test, and the positive reborrow test.Limitation: The guard may prevent some otherwise safe optimizations. Its performance impact has not yet been measured.