sometimes impossible to recover on infinite loop crash #91

Activity

1. trusktr commented on Mar 29, 2022

   

   trusktr

   on Mar 29, 2022

   ContributorAuthor

   More actions

   As a temporary workaround, I close the tab, re-open it then quickly copy the whole text, close it, open a fresh empty playground, paste the modified text with the following added to the top to prevent it from looping:

   thro();
   function thro() {
     throw "";
   }

   The thro() function is needed so that a plain throw statement doesn't break type checking, because TS thinks the lines after it are unreachable.
2. amoutonbrady commented on Apr 2, 2022

   

   amoutonbrady

   on Apr 2, 2022

   Last edited by amoutonbrady

   Member

   More actions

   Interesting! I've thought about adding a "run" button but need to think a little bit more how to display that in the UI. Probably would take the form of a checkbox to toggle auto refresh and a button that would appear when that option would be checked.
   As per the infinite loop issue, I'd like for the playground to automatically figure things out. Codesandbox has an option for that as well.
   

   I wonder if looking for every JS loop and adding a counter in it which would throw if the increment is over 10k or something would be sufficient...
3. ryansolid commented on Apr 3, 2022

   

   ryansolid

   on Apr 3, 2022

   Member

   More actions

   Solid does have some infinite loop protection. But it only works in tight loops. I imagine if you are hitting one here it is a larger one. This makes me think it is unlikely a simple loop counter will work.
4. amoutonbrady commented on Apr 3, 2022

   

   amoutonbrady

   on Apr 3, 2022

   Member

   More actions

   Oh thanks Ryan for the quick heads-up, I had no idea Solid had some of this built-in! Yeah I see, I need to dig this a little bit more. It's very possible the run button in itself would be more than enough.
5. milahu commented on Sep 14, 2022

   

   milahu

   on Sep 14, 2022

   Last edited by milahu

   More actions

   this makes the solidjs playground hang forever

   bad

   import { render, For } from "solid-js/web";
   import { createSignal, children } from "solid-js";
   import { createStore } from "solid-js/store";
   
   function Button(props) {
     const getChildren = children(() => props.children);
     const getOnClick = children(() => props.onClick); // FIXME
     return (
       <button type="button" onClick={(() => props.onClick)()}>
         <For each={getChildren()}>{item => <div>{item}</div>}</For>
       </button>
     );
   }
   
   function App() {
     const [store, setStore] = createStore({ count: 0 });
     const increment = () => {
       setStore('count', store.count + 1);
       console.log(`store.count=${store.count}`);
     };
     return (
       <Button onClick={increment}>
         {store.count}
       </Button>
     );
   }
   
   render(() => <App />, document.getElementById("app")!);

   good

   import { render, For } from "solid-js/web";
   import { createSignal, children } from "solid-js";
   import { createStore } from "solid-js/store";
   
   function Button(props) {
     const getChildren = children(() => props.children);
     const getOnClick = () => props.onClick;
     return (
       <button type="button" onClick={getOnClick()}>
         {getChildren()}
       </button>
     );
   }
   
   function App() {
     const [store, setStore] = createStore({ count: 0 });
     const increment = () => {
       setStore('count', store.count + 1);
       console.log(`store.count=${store.count}`);
     };
     return (
       <Button onClick={increment}>
         {store.count}
       </Button>
     );
   }
   
   render(() => <App />, document.getElementById("app")!);

   diff

    function Button(props) {
      const getChildren = children(() => props.children);
   -  const getOnClick = children(() => props.onClick); // FIXME
   +  const getOnClick = () => props.onClick;
      return (
   -    <button type="button" onClick={(() => props.onClick)()}>
   -      <For each={getChildren()}>{item => <div>{item}</div>}</For>
   +    <button type="button" onClick={getOnClick()}>
   +      {getChildren()}
        </button>
      );
    }
6. mtranggit commented on Apr 25, 2023

   

   mtranggit

   on Apr 25, 2023

   More actions

   You can delete the cache of the crashing code from browser localStorage for the solidjs playground site
7. trusktr commented on Sep 25, 2023

   

   trusktr

   on Sep 25, 2023

   ContributorAuthor

   More actions

   Oh yeah, right! Now that the playground remembers your previous code, refreshing always gets back to crashing state. :D