chore(size): batch re-record after #4529, #4533, #4494, #4534, #4532 by ryansolid · Pull Request #4537 · solidjs/solid

ryansolid · 2026-10-31T09:51:48Z

Before: on next @ 3a73a36, "app: compiled hydrating" is 31 B over its brotli cap, and six rows sit 6–19 B over their recorded minified, close to the 20 B allowance. The next PR that touches them would fail the size gate on bytes it didn't add.

After: one ledger re-record for the batch. Only one cap rises, compiled hydrating, and its minified actually fell. The six drifted rows get their recorded minified updated. Floor caps are unchanged.

This follows the batch process: fix PRs don't edit scripts/size, and the scan thread re-records once after a batch merges. The maintainer accepted the store-row growth from #4533 and #4534.

Row	Cap	Recorded minified	Moved by
app: compiled hydrating	32.56 → 32.61 KB	100,886 → 100,851 (−35)	brotli layout from #4494's renamed fields; minified fell
app: CSR with Show/For/…	13.47 KB (unchanged)	37,028 → 37,047 (+19)	#4532 (+5), #4533 (+3), earlier drift
app: CSR, observe tier	15.20 KB (unchanged)	41,982 → 42,001 (+19)	same
app: CSR, observe tier + attribution	29.80 KB (unchanged)	88,329 → 88,335 (+6)	#4532, #4533
app: hydrating (no stores) — floor	18.80 KB (unchanged)	53,611 → 53,617 (+6)	#4532, #4533
page: base server components — floor	33.81 KB (unchanged)	101,740 → 101,748 (+8)	#4532, #4533
page: live server components — floor	39.10 KB (unchanged)	118,123 → 118,140 (+17)	#4532, #4533, earlier drift

"hydrating + every store" doesn't need a re-record. #4494's rename puts it 43 B under its recorded minified even after #4529 and #4534. Hello world is 9,971 B, under its 9.98 KB cap, which is not raised.

How: the numbers are measured locally (linux) on next @ 3a73a36 with scripts/size/size.mjs. If CI's head numbers differ, a follow-up commit will set the re-recorded rows to CI's values. Each row gets one dated ledger line.

Size-Exception: re-records recorded minified on three frozen floors (hydrating no-stores, base server components, live server components). Their caps are unchanged. The growth comes from merged, accepted correctness fixes (#4529, #4533, #4532).

Generated by Claude Code

Raises the compiled hydrating cap (32.56 -> 32.61 KB; minified fell 35 B, the brotli rise is mangle layout from #4494) and re-records minified on six rows that drifted toward the 20 B allowance. Floor caps are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

changeset-bot · 2026-10-31T09:51:54Z

⚠️ No Changeset found

Latest commit: e498698

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-31T09:54:47Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.41 KB	−5 B	7.43 KB	✅
signals: + createStore	14.98 KB	−41 B	14.99 KB	✅
signals: + isPending/latest	11.37 KB	−4 B	11.40 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.04 KB	−3 B	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.76 KB	−5 B	9.80 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.75 KB	0 B	18.80 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.50 KB	−43 B	32.51 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.46 KB	0 B	13.47 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.18 KB	0 B	15.20 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.78 KB	0 B	29.80 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.97 KB	−3 B	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.32 KB	−35 B	26.36 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.59 KB	0 B	32.61 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.79 KB	0 B	33.81 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.20 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	39.09 KB	0 B	39.10 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.19 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.71 KB	−1 B	35.74 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.18 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	43.05 KB	+1 B	43.06 KB	✅	eager (counted): web.js 23.00 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.21 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.19 KB	−22 B	41.25 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.14 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.67 KB	+1 B	48.69 KB	✅	eager (counted): client.js 28.15 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.15 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	0 B	1.29 KB	✅
server: renderToString (the server-render floor)	22.85 KB	0 B	22.87 KB	✅

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-10-31T10:01:26Z

Coverage Report for CI Build 41190406427

Coverage remained the same at 78.134%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1367
Covered Lines:	1129
Line Coverage:	82.59%
Relevant Branches:	1098
Covered Branches:	797
Branch Coverage:	72.59%
Branches in Coverage %:	Yes
Coverage Strength:	30.03 hits per line

💛 - Coveralls

codspeed · 2026-10-31T10:06:10Z

Merging this PR will degrade performance by 0.18%

2 warnings

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 198 untouched benchmarks
⏩ 5 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`memo + sync render effect only (reference)`	28.4 ms	31.9 ms	-10.92%
⚡	`arrow in template`	12.4 ms	11.1 ms	+11.85%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/project-thread-x1ore2-ledger-3a73a36 (e498698) with next (d9aa8f7)²}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on next (3a73a36) during the generation of this report, so d9aa8f7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

ryansolid merged commit 215c365 into next Oct 31, 2026
8 checks passed

Navigation Menu

Repository navigation

chore(size): batch re-record after #4529, #4533, #4494, #4534, #4532 - #4537

chore(size): batch re-record after #4529, #4533, #4494, #4534, #4532#4537
ryansolid merged 1 commit into
nextfrom
claude/project-thread-x1ore2-ledger-3a73a36

ryansolid commented Oct 31, 2026

Uh oh!

changeset-bot Bot commented Oct 31, 2026

Uh oh!

github-actions Bot commented Oct 31, 2026

Uh oh!

coveralls commented Oct 31, 2026

Uh oh!

Uh oh!

codspeed Bot commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 31, 2026

Uh oh!

changeset-bot Bot commented Oct 31, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 31, 2026

Size (brotli, eager entry chunk)

Uh oh!

coveralls commented Oct 31, 2026

Coverage Report for CI Build 41190406427

Coverage remained the same at 78.134%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

Uh oh!

codspeed Bot commented Oct 31, 2026

Merging this PR will degrade performance by 0.18%

Performance Changes

Footnotes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants