Repository navigation
[6.x] Don't singularize default blueprint titles for non-English locales - #15655
Open
wakqasahmed wants to merge 1 commit into
Open
wakqasahmed wants to merge 1 commit into
wakqasahmed wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback blueprint for a collection or taxonomy with no saved blueprint gets its title from
Str::singular(), which only knows English rules. In a German CP, a collection titled "Aktuelles" ended up with a blueprint titled "Aktuelle", and "Verzeichnis" became "Verzeichni".This skips the singularization of the title when the app locale isn't English, for both collections and taxonomies. The fallback handle is left as is, since changing it would break entries already saved with the current handle.
I used an AI agent (Claude Code) to help with this change.
Fixes #15557