Repository navigation
fix(pm): prevent concurrent installs from exposing unfinished shims - #3248
Merged
fengmk2 merged 4 commits intoOct 27, 2026
Merged
Conversation
Create package manager shims and set their executable permissions in the temporary directory before publishing the installation. Keep the existing lock and post-lock completeness check for concurrent installers. Cover JavaScript package managers, Bun, and native pnpm with a regression test that checks shim readiness whenever the final directory is visible.
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
Author
|
@codex review |
jong-kyung
marked this pull request as ready for review
October 27, 2026 05:57
fengmk2
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Concurrent commands could execute a package manager shim before its executable permissions were set. Installers held a lock, but cache readers bypassed it and treated file existence as readiness.
Prepare shims and their permissions in the temporary directory before moving the installation to its final location. This covers JavaScript package managers, Bun, and native pnpm while preserving the existing installation lock and completeness recheck.