Skip to content

Main video stays paused when a playing video comment is removed #2796

Open

Description

@AksharP5

Description

Playing a video comment pauses the main share-page video. If the comment disappears before finishing, the main video stays paused instead of returning to its previous playing state. Switching the sidebar away from Comments or dismissing a timeline card can remove the player this way.

This affects inline comments, expanded mini players, and removal while the lazy mini player is still loading. A main video that was paused before the comment should stay paused.

Reproduction

  1. Open a share page containing a video comment and start the main video.
  2. Play the video comment in the Comments sidebar. The main video pauses.
  3. Before the comment ends, switch the sidebar to another tab.
  4. The comment disappears, but the main video remains paused. It should resume because it was playing before the comment took over.

The isolated reproduction mounts the actual comment players with the playback provider, store and registry, then removes the comment. It also covers expanding the inline comment and removing its host before the mini player loads.

Same native browser playback fixture Main Fixed
Remove playing inline comment Main stays paused, 0 resume calls Main resumes once
Remove expanded mini player Main stays paused, 0 resume calls Main resumes once
Remove card while mini player loads Main stays paused, 0 resume calls Main resumes once
Main initially paused Stays paused Stays paused

Additional Context

  • Baseline main: 88bce03d6d3ffdf1a23364792599fdf74a92bb77.
  • Chrome 154 on Linux x86_64, React 19.2.4.
  • The browser comparison uses native muted video playback of a synthetic video-only WebM. Comment playback advances before removal. Dialog/control chrome, motion and mini-player loading are fixtures. No authenticated share page, private media or external media service was used.
  • The same 12 focused tests produce 8 failures and 4 passes on main, then all pass after the fix.
  • Both players release their claim from passive cleanup, after React has cleared their video refs. The inline-to-dialog handoff can also clear the outgoing ref before the lazy mini player takes over.

Activity

  1. linear commented on Oct 21, 2026

    @linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions