Repository navigation
fix(web): resume playback when a video comment disappears - #2797
Merged
richiemcilroy merged 3 commits intoOct 22, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai please review the latest head, This restores main-video playback when a playing comment is removed, including removal during lazy mini-player loading. All 12 focused tests pass, and six native browser playback scenarios verify the before/after behavior. The PR describes the fixture boundaries and local tooling limitations. |
Member
|
Thanks @AksharP5! We've reviewed this and it looks good to merge. Our automated reviewer (Greptile) is temporarily not posting reviews; as soon as it scores this 5/5 and CI is green on the branch updated with main, we'll merge it. |
Member
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playing a video comment pauses the main video. Switching away from the comment before it ends left the main video paused, even when it had been playing beforehand.
Release playback during layout cleanup, before React detaches the player refs and the main-video interlock unregisters. Keep the outgoing element reachable while the lazy mini player loads, then clear it when that interaction ends or another player takes over. Expanding a comment still keeps the main video paused until the interaction finishes.
Closes #2796
Before and after
Same main baseline
88bce03d6, React 19.2.4 and Chrome 154 Linux fixture, using native muted video playback of a synthetic WebM.All six browser cases confirm that the comment really plays and its playback time advances before removal. React, the playback provider/store/registry, and native video play/pause are real. Dialog/control chrome, motion and dynamic-loading state are fixtures. No authenticated full-page or cloud playback was exercised.
Validation
git diff --checkpass. An independent review found no remaining issues.Focused repository command:
cd apps/web && bun run test __tests__/unit/media-comment-playback-cleanup.test.ts.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
This PR returns playback to the main video when a playing video comment disappears.
No actionable issues were found. Review checks were based on source inspection; tests and browser playback were not run during this review.
Reviews (1) · Last reviewed commit: "chore(web): update playback fix with mai..." · Reviewed by Greptile