Repository navigation
Git: Add missing package import org.ietf.jgss to JGIT packages - #9755
matthiasblaesing wants to merge 1 commit into
Conversation
2976c49 to
86c38bf
Compare
| The NetBeans module org.eclipse.jgit.ssh.apache is just a repackaging | ||
| of the original bundle, with org.ietf.jgss added to the Import Package | ||
| list. | ||
| --> |
There was a problem hiding this comment.
- as written at Netigso: Align OSGI framework bootdelegation with Equinox #9756 (review)
- patching the
jgitmodule now and - sending a fix upstream is my preferred solution
There was a problem hiding this comment.
I think this is not a sustainable solution. I tried to get a patch into jgit and it is still bitrotting. Maybe that changed and they are more open, but my gut feeling is, that more project have broken imports and thus will break. So for a hotfix I would go with #9756 if that works.
There was a problem hiding this comment.
... not a sustainable solution...
- patching upstream projects in NetBeans repository isn't sustainable solution
- submitting patches to upstream projects is (in my opinion) the only sustainable solution
- please submit the patch to jgit and reference it here
...more project have broken imports...
- that's possible, but unless we know about them it is just a guess
- once we find such a project, we should (again) submit patch upstream (in my opinion)
hotfix I would go with #9756 if that works.
- that's probably safest bet for NetBeans 32 - feel free to do it
- for
masterI'd rather stick to Felix/OSGi spec and fix broken OSGi module imports one by one - with a bit of luck we'll fix them all by NetBeans 33
There was a problem hiding this comment.
for
masterI'd rather stick to Felix/OSGi spec and fix broken OSGi module imports one by one
That is not how this works! The commit in #9756 will sync to master from delivery. Nothing ever lands only in the release.
I agree with @matthiasblaesing that patching here is not a sustainable nor desirable option, from a technical and provenance point of view. So, as and until any built-in dependencies don't require it, we're stuck with that.
And -1 to this.
There was a problem hiding this comment.
- I know that
deliveryis synced both ways (the release, as well asmaster)
patching here is not a sustainable
- Exactly!
- Hence I want us to (try to) solve the issue upstream.
There was a problem hiding this comment.
The comment seemed to suggest not merging to master. Sorry if I read that wrong.
We all want upstream fixed! But @matthiasblaesing has looked into this issue the most, and happy to leave it to his call on the best approach.
If everything is otherwise equal, I do prefer a time-limited opening of the configuration over patching. I do prefer keeping binary identity of third-party deps, and I'm unsure if we've definitely covered every base on the imports? It's obvious upstream isn't automating and testing for this.
86c38bf to
03fc8c3
Compare
Both org.eclipse.jgit and org.eclipse.jgit.ssh.apache are missing imports for org.ietf.jgss causing ClassNotFoundExceptions when Negotiate/Kerberos Authentication is invoked. Closes: apache#9751
03fc8c3 to
64cb18e
Compare
|
JGit Changerequest: https://gerrithub.io/c/eclipse-jgit/jgit/+/1257440 |
Both org.eclipse.jgit and org.eclipse.jgit.ssh.apache are missing imports for org.ietf.jgss causing ClassNotFoundExceptions when Negotiate/Kerberos Authentication is invoked.
Closes: #9751