Repository navigation
Netigso: Align OSGI framework bootdelegation with Equinox - #9756
Open
matthiasblaesing wants to merge 1 commit into
Open
matthiasblaesing wants to merge 1 commit into
matthiasblaesing wants to merge 1 commit into
Conversation
Apache Felix by default only uses java.* as list for bootdelegation. This differs from eclipse, which uses: javax.*, org.ietf.jgss, org.omg.*, org.w3c.*, org.xml.*, sun.*, com.sun.* At least one module (jgit) makes this assumption and the author of this commit assumes that there are more modules doing the same. Closes: apache#9751
Member
|
target meant to be delivery, right? |
Contributor
Author
Yes indeed. What a coincidence, that the CI/CD infrastructure did not yet run the job 😃 |
jtulach
approved these changes
Oct 28, 2026
Contributor
There was a problem hiding this comment.
The change is OK short term, but in the long term horizon we should do better:
module (jgit) makes this assumption
- Can we sent a patch upstream to make jgit compatible with Felix and pure OSGi spec?
- Can we remove these extra packages then?
- using
Constants.FRAMEWORK_BOOTDELEGATIONis a fine workaround, but only a workaround - the core idea of OSGi is isolation and expanding the list of system packages violates the isolation
- using
- Alternatively: can we patch
jgitnow, and them fix the problem by upgrading?- attempted at #9755
| // https://github.com/eclipse-equinox/equinox/blob/7d9c3b69eae96c977f7f97add730a4d679060002/bundles/org.eclipse.osgi/JavaSE-9.profile#L244-L251 | ||
| configMap.merge( | ||
| Constants.FRAMEWORK_BOOTDELEGATION, | ||
| "javax.*, org.ietf.jgss, org.omg.*, org.w3c.*, org.xml.*, sun.*, com.sun.*", |
Contributor
There was a problem hiding this comment.
- is it reasonable to export package that aren't visible by the JPMS?
- e.g.
sun.*andcom.sun.**seem to contradict the direction JDK is heading - if there is a code that really needs these packages, then OK, ...
- ...but otherwise, I'd suggest to avoid exporting these non-public JDK packages
- e.g.
- exporting
javax,org.w3c, ororg.xmlis OK - Is
org.omgstill in the JDK21+?
neilcsmith-net
approved these changes
Oct 28, 2026
neilcsmith-net
left a comment
Member
There was a problem hiding this comment.
Makes sense. Thanks for looking into this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apache Felix by default only uses java.* as list for bootdelegation.
This differs from eclipse, which uses:
At least one module (jgit) makes this assumption and the author of this commit assumes that there are more modules doing the same.
Closes: #9751