Repository navigation
fix(v10/nitro): Use forward slashes for resolved plugin paths on Windows - #25692
Merged
Merged
Conversation
Backport of: #25023 Co-Authored-By: GPT-6 <codex@openai.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 74caa17. Configure here.
| const resolver = createResolver(import.meta.url); | ||
|
|
||
| expect(resolver.resolve('../runtime/plugins/server')).not.toContain('\\'); | ||
| }); |
There was a problem hiding this comment.
Regression test never fails on CI
Low Severity
The new unit test asserts that createResolver never returns backslashes, but path.resolve on Linux and macOS already uses forward slashes, so this check passes even without the Windows normalization. CI only runs on Ubuntu, so the regression this fix targets is not actually locked in.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 74caa17. Configure here.
nicohrubec
marked this pull request as ready for review
October 23, 2026 10:28
nicohrubec
requested review from
chargome and
s1gr1d
and removed request for
a team
October 23, 2026 10:28
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Oct 23, 2026
49 of 54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25023