Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/nitro/src/utils/resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ export function createResolver(base: string): Resolver {
}

return {
resolve: (...path) => resolve(resolvedBase, ...path),
// Nitro writes plugin paths verbatim into a generated `import "…"` statement, where the
// backslashes of a Windows path read as escape sequences (`C:\Users` becomes `C:Users`).
// Forward slashes resolve on every platform, so normalize to them.
resolve: (...path) => resolve(resolvedBase, ...path).replace(/\\/g, '/'),
};
}
16 changes: 16 additions & 0 deletions packages/nitro/test/resolver.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { describe, expect, it } from 'vitest';
import { createResolver } from '../src/utils/resolver';

describe('createResolver', () => {
it('resolves relative to the directory of a file URL', () => {
const resolver = createResolver(import.meta.url);

expect(resolver.resolve('../src/utils/resolver.ts')).toMatch(/packages\/nitro\/src\/utils\/resolver\.ts$/);
});

it('never returns backslashes, so the path survives being written into an import string', () => {
const resolver = createResolver(import.meta.url);

expect(resolver.resolve('../runtime/plugins/server')).not.toContain('\\');
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression test never fails on CI

Low Severity

The new unit test asserts that createResolver never returns backslashes, but path.resolve on Linux and macOS already uses forward slashes, so this check passes even without the Windows normalization. CI only runs on Ubuntu, so the regression this fix targets is not actually locked in.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 74caa17. Configure here.

});
Loading