Repository navigation
fix(host): name the project shares that stopping the directory deletes - #642
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping the directory a host serves deletes every project share, but the confirmation only said "its shares are deleted". It now names them, grouped by project:
With no shares it says only the first part. Diagnostics carries the served directory's shares (
directory.shares), read straight from its database.Part of #631: the second half, teammates who lose access seeing "no longer shared with you" instead of "Offline", is not in this PR. It needs two Macs on a tailnet to see work, and a choice of how a reachable peer's withheld channels are listed. Map: ^113, ^361.
Smoke: loopback source host with its own
ACE_HOME, serving a directory whose database held a team share of a folder project and two person shares of a GitHub project. Headless Chromium, Settings → Team → Stop serving… showed the sentence above; Stop serving then reported "Stopped serving the directory." and the database was gone. With no shares the confirmation read "…on offline Macs."Built in Ace
No: made from Claude Code (a fix-train worker), with a headless Chromium to drive Settings. Dogfooding gap tracked in #5.