Repository navigation
Conversation
Fix the Japanese of the TiDB Cloud BYOC docs that the 2026-10-16 sync (pingcap#24472) added without review: - Translate headings, table headers, labels, link texts, and lowercase nouns left in English (hosted zone → ホストゾーン, bastion host → 踏み台ホスト, observability → 可観測性, quota, certificate authority, resource pool CIDR, and others), and use 「ステップ N.」 for steps. - Fix TOC entries that do not follow existing terms or target titles (列プルーニング, 実行プランキャッシュ, 集計, 購読, 階層型ストレージ, and translated page titles). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
📝 Walkthrough
Merge Risk: 🟡 Moderate · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the localization and terminology fixes in the TiDB Cloud BYOC documentation. |
| Description check | |
The description explains the scope, motivation, affected files, target release branch, related PRs, AI involvement, and change categories. It is complete for the required sections. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (8 skipped: 8 unsupported.)
✨ Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Use 「AWS マネジメントコンソール」, the name AWS uses in Japanese and the majority form in the docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a81acbe to
2bd8a84
Compare
…C docs The sync rendered "observability" both as 可観測性 and as オブザーバビリティ in the BYOC docs. Use オブザーバビリティ, the form commonly used in the industry, in all BYOC docs. The BYOC TOC entry for the tiered storage observability page keeps 可観測性 to match that page's title and the Premium TOC; other docs are left for a separate change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9182b8a to
aa2a33a
Compare
…preparation doc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🔇 Additional comments: 3
tidb-cloud/byoc/create-resource-pool-byoc.md: 1
12-12: LGTM!Also applies to: 47-47, 59-59
tidb-cloud/byoc/manage-resource-pools-byoc.md: 1
46-46: LGTM!Also applies to: 68-68
tidb-cloud/byoc/byoc-prepare-environment-aws.md-130-137: 1
130-137: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Translate the remaining table labels.
The column headers are Japanese, but the required-information table still uses English item names and example labels. Translate these user-facing labels while keeping AWS product names, IDs, and acronyms unchanged.
| **TiDB Cloud 組織 ID** | TiDB Cloud 組織の一意識別子 | `1372813089209270552` | ステップ 1 | | **AWS アカウント ID** | 12 桁の AWS アカウント番号 | `123456789012` | ステップ 2 | | **AWS リージョン** | デプロイ用に選択したリージョン | `us-west-2`, `us-east-1`, `us-east-2` | ステップ 3. マルチリージョン デプロイの場合は、すべてのリージョンを列挙してください。 | | **アベイラビリティゾーン** | リージョンごとに 3 つの AZ または単一 AZ (名前と ID を指定) | **Us-east-1:** `us-east-1a`, `use1-az1`, `us-east-1b`, `use1-az2`, `us-east-1c`, `use1-az4`; **Us-east-2:** `us-east-2a`, `use2-az1`, `us-east-2b`, `use2-az2`, `us-east-2c`, `use2-az3`; **Us-west-2:** `us-west-2a`, `usw2-az1` | ステップ 3. 選択した**各**リージョンで AZ 数の要件を満たすよう注意してください。 | | **下位 CA ARN** | AWS ACM Private CA ARN | `arn:aws:acm-pca:us-west-2:123456789012:ca/abcd-1234` | ステップ 5. この ARN は複数リージョンで共有できます。 | | **ホストゾーン名とホストゾーン ID** | TiDB ホストゾーン。パブリックホストゾーンまたはプライベートホストゾーンのいずれかを指定できます。 | **TiDB ホストゾーン名:** `clusters.byoc-0929.pingcap.net`; **TiDB ホストゾーン ID:** `Z1039122VAY4T8UNWR8E`. | ステップ 4. ホストゾーンは複数リージョンで共有できます。 | | **CIDR** | O11Y インフラストラクチャおよびリソースプール用にお客様が計画した CIDR 範囲 | **O11Y CIDR:** `10.1.0.0/22`; **リソースプール CIDR:** `10.10.0.0/16` | ステップ 6 | | **イメージ同期リージョン** | イメージ同期用に選択したリージョン ID | `us-west-2` | 詳細は [イメージ同期](/tidb-cloud/byoc/byoc-automated-deployment.md#step-1-image-synchronization) を参照してください。 |
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: pingcap/docs/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
2597bfee-b65d-44f5-b365-5b85168c4776
📒 Files selected for processing: 13
TOC-tidb-cloud-byoc.mdtidb-cloud/byoc/byoc-automated-deployment.mdtidb-cloud/byoc/byoc-configure-bastion-host.mdtidb-cloud/byoc/byoc-configure-iam-permissions.mdtidb-cloud/byoc/byoc-initialize-service.mdtidb-cloud/byoc/byoc-onboarding-overview.mdtidb-cloud/byoc/byoc-prepare-environment-aws.mdtidb-cloud/byoc/create-resource-pool-byoc.mdtidb-cloud/byoc/create-tidb-instance-byoc.mdtidb-cloud/byoc/joint-validation.mdtidb-cloud/byoc/manage-resource-pools-byoc.mdtidb-cloud/byoc/multi-region-deployment.mdtidb-cloud/byoc/security-hardening.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.
Use 「MySQLシンクへ」, 「Kafkaシンクへ」, and 「クラウドストレージへ」, as TOC-tidb-cloud.md does; the cloud storage page title is 「クラウドストレージへのシンク」. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5c576e3 to
d30d428
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
🟡 Minor · Resolve the audit-log link check failure. · byoc-configure-bastion-host.md:180
tidb-cloud/byoc/byoc-configure-bastion-host.md:180
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winResolve the audit-log link check failure.
Lychee receives HTTP 403 for the Red Hat auditd link, so the Links workflow exits with code 2. The page is currently available, which indicates an automated-check access problem rather than a missing page. (docs.redhat.com) Use a checker-compatible official URL or update the link-check configuration for this host and status.
Source: Pipeline failures
🔇 Additional comments: 4
TOC-tidb-cloud-byoc.md: 2
62-62: LGTM!Also applies to: 89-95, 112-117, 133-137, 149-151, 166-166, 180-186, 284-284, 372-372, 478-478, 493-499, 510-510
199-199: 🎯 Functional CorrectnessThe old
#referencefragment must be checked before changing the heading. If a link uses that fragment, preserve an explicit#referenceanchor or update the link.tidb-cloud/byoc/byoc-onboarding-overview.md: 1
18-22: LGTM!tidb-cloud/byoc/manage-resource-pools-byoc.md-68-68: 1
68-68: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Pool vCPU Limit の対象を明確にしてください。
現在の文は、上限の対象と「任意」の意味を読み取りにくくします。Pool vCPU Limit が、リソースプールで許可されるプロビジョニング済み TiDB vCPU キャパシティの上限を顧客が定義する設定であることを明示してください。
コミット可能な修正
-Pool vCPU Limit は、リソースプールに対して許可される最大のプロビジョニング済み TiDB vCPU キャパシティについて、顧客が任意で定義できる上限です。管理ノードや可観測性ノードなどの追加 vCPU プロビジョニングは、この上限には含まれません。 +Pool vCPU Limit は、リソースプールで許可されるプロビジョニング済み TiDB vCPU キャパシティの上限を顧客が定義するための設定です。管理ノードや可観測性ノードなどの追加 vCPU プロビジョニングは、この上限に含まれません。
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: pingcap/docs/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
22209e2f-5d54-4c16-9bbc-286660d6e7a8
📒 Files selected for processing: 8
TOC-tidb-cloud-byoc.mdtidb-cloud/byoc/byoc-automated-deployment.mdtidb-cloud/byoc/byoc-configure-bastion-host.mdtidb-cloud/byoc/byoc-initialize-service.mdtidb-cloud/byoc/byoc-onboarding-overview.mdtidb-cloud/byoc/byoc-prepare-environment-aws.mdtidb-cloud/byoc/joint-validation.mdtidb-cloud/byoc/manage-resource-pools-byoc.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.
What is changed, added or deleted? (Required)
The 2026-10-16 syncs #24467 and #24472 were merged without a review. This is one of four PRs that fix the Japanese they added or changed, reviewed line by line against the English (
1b1d01f8...e65d1259). The four PRs touch different files and can be merged in any order. This PR fixes the new TiDB Cloud BYOC docs (tidb-cloud/byoc/andTOC-tidb-cloud-byoc.md).byoc-prepare-environment-aws.mdandmanage-resource-pools-byoc.md(3 lines; the EBS volume capacity stays 容量). The rest of this term change is in i18n(ja): use the katakana term for compute capacity in TiDB Cloud and RU docs #24497; these lines are fixed here because this PR also edits them.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit