Repository navigation
Conversation
1286e7c to
f549d37
Compare
|
Man i just wanted to check if cosmic is available in void linux! |
Have you played with void-packages? You can pull this PR and build it and start playing with it! I'm running it with no systemd and it seems ok... There seems to be something with the sound but idk if that just my system. So testers are welcome! |
|
Thanks for working on this! |
|
Thanks for getting this PR up! I've been looking forward to it. I built and tested the full cosmic desktop. The issues I've encountered so far are being unable to launch Anyone able to replicate those issues, or is it just my system? |
|
@EllisK-L what kind of issue are you seeing with A bit of context about my setup, I'm using An issue I saw was that my sound was not recognized, but running 
I'm looking forward to hear more opinions and see how the thing is working in other people's machines... I'm still daily-driving plasma out of habit but I think I'm gonna throw some more hours at cosmic to see how stable it feels and what other sharp edges might be found. |
|
I also launched cosmic with sddm, I don't think I tested audio, I can when I'm back at that system. Here's an example of 
|
|
@EllisK-L you are right! Just fixed it, the issue was that |
|
Alright, just pushed a few more changes, mostly dealing with adapting COSMIC to Void Linux!
Now looking into why the CI is failing |
5fc3d09 to
5808787
Compare
|
Update it to COSMIC 1.5.0? |
bro... 😄 |
|
Thank you for making this branch available, I will plan myself to test it in VM and on my test hardware machine. |
|
To the people here... COSMIC 1.5.0 just dropped... do we polish this version (1.4.0) and get it into void or do we jump straight to 1.5.0? |
|
hmmm, Cosmic gets updates about every week, it's very possible this PR will take another week+ before it's merged. Since we're still pretty early in the testing phase of this PR updating to 1.5 probably wont hurt. But making sure it's polished in Void should be the focus. Up to you though as the PR authour :) |
|
LLM didn't generate these. I started from this abandoned PR, updated versions, build, deleted unneeded patches, added missing (or renamed) packages, tested, debugged, etc. There was not "make COSMIC packages for void Linux" prompt. I indeed used tons of AI for debugging and doing high level comparisons between how Arch and Artix Linux (Arch without systemd) packaged cosmic for their distro. I typed stuff in the templates, other times the agent typed stuff in the templates. It is very much a hybrid. By vibecoding I interpret not that an AI agent was used, but instead low effort "here's a few hundred lines of code that compile, maintainers... can you please merge?" The evidence of the effort and work is in the, now 52 messages in the PR since June. If this is considered vibecodded Idk what to tell you 🤷♂️ |
|
CONTRIBUTING.md never uses the term "vibecoding", it says |
"Just" chiming in - it's not only about what you need to do, but this set of packages needs to be reviewed and approved by at least one void member, and whenever LLMs have been utilized in order to create package templates, it will always be the "elephant in the room" - also when it comes to future maintainability (and there's always the chance that packages will become orphaned at some point). Anyway, after skimming the templates, could you explain the need for certain dependencies (e.g. Personally I'm not interested in using the cosmic desktop - just curious, since merging this set of interdependencies might potentially stall future updates, e.g. when there's the need for rebuilding against shared libraries. EDIT: There's no need to quote me entirely and inflate this thread - I've stated my personal concerns, but you will have to wait for a member to chime in. Also, @benjcal has not mentioned @Calandracas606 (nor any agent, for that matter) as co-authors in any commit message yet, as per CONTRIBUTING.md @mendescotta Why do you refer to archlinux.org? |
https://archlinux.org/packages/extra/x86_64/pop-launcher/ |
|
Ok so... what I'm seeking for is guidance, not to start a conflict on the already hot topic of AI... we all have opinions and I just want to understand what are the rules for contributing here. Since AI conversations seem to have a lot to do with intention and hair splitting (did you pressed the keys to type the characters in the code or did an AI agent typed those characters...) I'm not trying to contribute here to get internet points, a merge here (which I already have a few) doesn't make me more employable or whatever, also this is volunteer work and if we are not able to keep it interesting and engaging we risk losing the community that makes open source software possible. @dogknowsnx About the co-author, thank you for the guidance, I'll fix that oversight. About the use of There are some packages that build fine with the cargo build that As @mendescotta mentioned, those other packages are requirements for cosmic. The two places I've referenced the most of these templates are https://archlinux.org/groups/x86_64/cosmic/ and https://github.com/pop-os/cosmic-epoch I think what felt rather unfortunate was in a PR with like 50 messages, about a dozen people testing this, multiple iterations and back and forth testing and updates over the last three months, the blocker is "did you physically typed the characters in the text files"? I completely understand the issue, I don't want to review AI code either, but dang dude, not a single glance at anything else in the PR? in the message history? come on |
|
As much as I like to avoid vibecoding, I think if it was just used as an aid here and every line is understood and and reviewed by the author (which it sounds like it is), we can move on from that conversation. Unless a core maintainer says otherwise, I'd just focus on wrapping up the other points of conversation. The only such topic seems to be the "settings for the top/bottom panel and the dock" missing. That topic didn't sound like it reached a conclusion. It'd be good to hear from a core maintainer if they have any thoughts. I'd like to see this go in, too. |
Again, I'm not a member, but that's not what I would expect from a quality PR
This, on the other hand, I would expect from a quality PR, since defining EDIT: Fwiw, I randomly picked EDIT2: Another observation is that despite defining |
|
At this point I'm more than happy to pass the torch. For my COSMIC needs I'm fine running this with my own build, but I at the moment no longer have the time to keep working on this. |
|
@dogknowsnx what is the problem with using Just? That's what upstream uses. |
|
1) It's not so much about which install method is being used, as it is about (unnecessarily) redefining I keep repeating myself while playing devil's advocate, but what you really want is the opinion and ultimately the interest in this project from a void member.. |
|
The custom For me the biggest issue is that the architecture is limited to |
| do_build() { | ||
| cargo build --release --locked --target ${RUST_TARGET} | ||
| cargo build --release --locked --target ${RUST_TARGET} --package cosmic-files-applet | ||
| } |
There was a problem hiding this comment.
This doesn't exactly look like it needs to be overwritten, doesn't it build the same cosmic-files-applet twice?
Otherwise there are arguments like configure_args="--workspace" you can set if it doesn't build everything.
There was a problem hiding this comment.
Please no vendored configuration files.
| archs="x86_64*" | ||
| _tag=epoch-${version} | ||
| build_style=cargo | ||
| configure_args="--all" |
There was a problem hiding this comment.
| configure_args="--all" | |
| configure_args="--workspace" |
|
@Duncaen the reason for the restriction to |
I know the DE in general works on arm, since my friend built it from source to run on his macbook with void linux. |
|
Also is there a reason this uses llvm18, while llvm23 is current? |
|
The licensing is inconsistent, for some template its set as Each one should be reviewed and I guess upstream should clarify the license in case of cosmic-osd. |
| makedepends="libxkbcommon-devel glib-devel gstreamer1-devel gst-plugins-base1-devel" | ||
| short_desc="Media player for the COSMIC desktop" | ||
| maintainer="Benjamin Calderon <benj.calderon@gmail.com>" | ||
| license="GPL-3.0-or-later" |
There was a problem hiding this comment.
| license="GPL-3.0-or-later" | |
| license="GPL-3.0-only" |
https://github.com/search?q=repo%3Apop-os%2Fcosmic-player+gpl&type=code
| depends="geoclue2 acpid alsa-utils playerctl wireplumber xdg-utils" | ||
| short_desc="Settings daemon for the COSMIC desktop environment" | ||
| maintainer="Benjamin Calderon <benj.calderon@gmail.com>" | ||
| license="GPL-3.0-or-later" |
There was a problem hiding this comment.
https://github.com/search?q=repo%3Apop-os%2Fcosmic-settings-daemon+gpl&type=code
inconsistent, -or-later in Cargo.toml, but -only in SPDX identifiers and debian/contorl.
| makedepends="libxkbcommon-devel pulseaudio-devel eudev-libudev-devel libinput-devel" | ||
| short_desc="On-Screen Display daemon for the COSMIC desktop" | ||
| maintainer="Benjamin Calderon <benj.calderon@gmail.com>" | ||
| license="GPL-3.0-or-later" |
There was a problem hiding this comment.
As mentioned in another comment, inconsistent, but more likely -only.
https://github.com/search?q=repo%3Apop-os%2Fcosmic-osd+gpl&type=code
| depends="xdg-desktop-portal" | ||
| short_desc="Backend implementation for xdg-desktop-portal for COSMIC" | ||
| maintainer="Benjamin Calderon <benj.calderon@gmail.com>" | ||
| license="GPL-3.0-or-later" |
There was a problem hiding this comment.
| build_style=cargo | ||
| hostmakedepends="pkg-config just clang lld" | ||
| makedepends="libxkbcommon-devel libqalculate-devel" | ||
| depends="fd bash xdg-utils" |
There was a problem hiding this comment.
Don't see where this needs "bash" specifically.
| depends="fd bash xdg-utils" | ||
| short_desc="Modular IPC-based desktop launcher service" | ||
| maintainer="Benjamin Calderon <benj.calderon@gmail.com>" | ||
| license="MPL-2.0, GPL-3.0-only" |
There was a problem hiding this comment.
| license="MPL-2.0, GPL-3.0-only" | |
| license="MPL-2.0 AND GPL-3.0-only" |
| do_build() { | ||
| export RUSTFLAGS="${RUSTFLAGS} -C link-arg=-fuse-ld=lld" | ||
| CC=clang just build-release --locked | ||
| } |
There was a problem hiding this comment.
This do_build seems unnecessary, looking at the justfile.
# Compile with debug profile
build-debug *args:
cargo build -p pop-launcher-bin {{args}}
# Compile with release profile
build-release *args: (build-debug '--release' args)
There was a problem hiding this comment.
Not sure about the clang/lld choice here, just for that single template, seems random.
|
Thanks a ton @Duncaen for the review and direction! I'll look into all of this and report back soon. |
|
@benjcal why is this closed now? do you need someone to take over? |
|
@edenian-prince yes |
Testing the changes
New package
Local build testing