Skip to content

fix(app): keep a teammate's name and order in offline sections, and return Team setup to Settings - #693

Merged
iamnbutler merged 3 commits into
mainfrom
fix-team-names
Oct 23, 2026
Merged

iamnbutler merged 3 commits into
mainfrom
fix-team-names

Conversation

@iamnbutler

Copy link
Copy Markdown
Contributor

Fixes the fix-queue item "Team setup and offline section names" (map ^120, ^104; #604, #607, #631).

  • Team setup (^120): when a teammate's host is already in a team (or a directory is offered), the first choice reads "Set up a separate directory / Your tailnet already has a team…" instead of "You're the first on this tailnet".
  • Team setup from Settings (^120): Settings → Team → Set up… now returns to Settings → Team when Team setup closes (✕, Done, Just me for now). Before, ✕ closed Settings too. Opening from the sidebar still closes cleanly.
  • Offline teammate sections (^104): in All Projects, a teammate section's owner is its own part of the header, so the project name is shortened first and the owner and · Offline stay visible. The header's title shows the full name on hover.
  • No re-sorting (^104): projects are added in channel creation order rather than the host's listing order. While a peer is offline, its listings move behind the directory's, and that used to re-sort projects known only through its channels.

Smoke-tested on an isolated bun ace serve from this lane (own ACE_HOME, config and keychain, port 5170), driven with headless Playwright:

  • With a teammate peer injected into team-peers, the fork shows the new copy with Join your team pre-selected. Closing it after opening from Settings → Team leaves exactly one dialog, Settings on Team. Opening from the sidebar and closing leaves none.
  • With an offline teammate channel injected into the listing, the header in a narrow sidebar reads a… · samechocolixir · Offline, and its title/aria-label carry the full name.
  • With the listing order flipped, this build keeps the same section order. The old projects.ts, rebuilt and run on the same flipped input, swaps them.

I first tried stacking Team setup over Settings. Base UI then mounted extra Settings dialogs behind it, so I switched to returning to the section instead.

Built in Ace

No. A Claude Code fix-train worker (fixw17) built this from a terminal, and headless Playwright drove an isolated bun ace serve. Ace has no way yet to run this queue's parallel agents or browser automation against a separate host instance (#5).

…eturn Team setup to Settings

Why: apps/app/src/projects.ts#function projects | projects follow channel creation order, not the host's listing order, which moves an offline peer's listings behind the directory's
@iamnbutler
iamnbutler merged commit 370b009 into main Oct 23, 2026
1 check passed
@iamnbutler
iamnbutler deleted the fix-team-names branch October 23, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant